Size optimise NRF SDK build #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
|
I can't remember why we specified -O3 specifically for that target. The history is not clear about that, it was changed from -Os back and forth to -O3 multiple times with many merges... :/ I guess we can merge this if you didn't notice any unwanted side-effects :) |
|
I think if we wanted to O3 a specific part it would make the most sense to do that to LVGL as that's the biggest CPU cruncher. But I haven't had time to try that yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the NRF SDK is built with -O3 rather than -Os like with everything else
This saves a bit of flash space and performance seems unchanged to me. Thoughts on this change? I could definitely see the performance improvement being justified if it exists, but I don't have a profiler or anything.