Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD delay improvements #2043

Merged
merged 4 commits into from
May 1, 2024
Merged

LCD delay improvements #2043

merged 4 commits into from
May 1, 2024

Conversation

mark9064
Copy link
Member

  • No longer spins the CPU when the display task is waiting
  • Unnecessary waits removed
  • Sleep in - sleep out minimum interval now respected

This all assumes the datasheet is correct :P It could definitely be inconsistent in places
I'd appreciate if it at least one reviewer could check that they interpret the datasheet the same way
https://wiki.pine64.org/images/5/54/ST7789V_v1.6.pdf
See pages 48, 49, 163, 182, 184

Split from #1869

Copy link

github-actions bot commented Mar 22, 2024

Build size and comparison to main:

Section Size Difference
text 377528B 48B
data 940B 0B
bss 63548B 8B

@mark9064
Copy link
Member Author

(InfiniSim PR now ready)

@mark9064 mark9064 mentioned this pull request Mar 31, 2024
Copy link
Collaborator

@JF002 JF002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I can't remember why I added those delays in St7789::ColMod(), St7789::DisplayInversionOn(), St7789::NormalModeOn() and a few other methods. It seems to work fine without them (and I trust you made those changes according to the data sheet anyway :) ).

@JF002 JF002 added this to the 1.15.0 milestone Apr 7, 2024
@JF002 JF002 merged commit 06c6935 into InfiniTimeOrg:main May 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants