Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix motion service not updating when sleeping #1970

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

FintasticMan
Copy link
Member

This PR fixes the motion service not being updated when the device is sleeping. This would only happen in the case that there is no motion-based wake-up mode enabled.

Thanks to @apilat for the implementation.

Fixes #1843.
Supersedes #1207.

@FintasticMan FintasticMan added the bug Something isn't working label Jan 15, 2024
@FintasticMan FintasticMan requested a review from a team January 15, 2024 21:22
Copy link

Build size and comparison to main:

Section Size Difference
text 369816B 32B
data 940B 0B
bss 63516B 0B

@FintasticMan FintasticMan added this to the 1.15.0 milestone Jan 17, 2024
Copy link
Contributor

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I can only assess the new code as I don't know much about the BLE services and when the 'issubscribed' boolean is set.

Could you also open an MR on InfiniSim to update the motion service there as well?

@FintasticMan FintasticMan merged commit a6cd367 into main Jan 23, 2024
6 of 7 checks passed
@FintasticMan FintasticMan deleted the fix_motion_service_sleep branch January 23, 2024 13:58
FintasticMan added a commit to FintasticMan/InfiniSim that referenced this pull request Jan 23, 2024
NeroBurner pushed a commit to InfiniTimeOrg/InfiniSim that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motion Controller issue when screen off
3 participants