Classifications Exports

[InCadence]

Coalesce Core is exporting the classification packages.

[bytemedwb]

So what makes this a bug?

[dclemenzi]

coalesce-classification and coalesce-core are exporting the same package with the same version. Therefore depending on which bundle the classes are imported from will determine the signature and make it incompatible with bundles loading the package from the other.

[dclemenzi]

This has not been seen on our project because we are not using the CAPCO markings. But Matt experienced this issue when attempting to upgrade their version.

[dclemenzi]

Only affects applications running in Karaf or other OSGi environments.

[bytemedwb]

So why do we have the packages with the same names and versions? Should one package not be named the same? Or should they be combined into one package (since signatures are different)? More curious than anything. On 2/26/19 10:04 PM, Derek Clemenzi wrote: coalesce-classification and coalesce-core are exporting the same package with the same version. Therefore depending on which bundle the classes are imported from will determine the signature and make it incompatible with bundles loading the package from the other. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#133 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADslzB9ymxCASBygeG4sTMHvmvg0lEYsks5vRfXCgaJpZM4bTax8>.

…

-- ========= mailto:dboyd@incadencecorp.com ============ David W. Boyd VP, Data Solutions 10432 Balls Ford, Suite 240 Manassas, VA 20109 office: +1-703-552-2862 cell: +1-703-402-7908 ============== http://www.incadencecorp.com/ ============ ISO/IEC JTC1 WG9, editor ISO/IEC 20547 Big Data Reference Architecture Chair ANSI/INCITS TC Big Data Co-chair NIST Big Data Public Working Group Reference Architecture First Robotic Mentor - FRC, FTC - www.iliterobotics.org<http://www.iliterobotics.org> Board Member- USSTEM Foundation - www.usstem.org<http://www.usstem.org> The information contained in this message may be privileged and/or confidential and protected from disclosure. If the reader of this message is not the intended recipient or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by replying to this message and deleting the material from any computer.

[dclemenzi]

We don't ... the maven-bundle-plugin will shade packages that are explicitly exported. Therefore when we explicitly tell it to export ${project.groupId}.common.* this also includes ${project.groupId}.common.classification which is a dependency. So the fix is to remove the wild card and only list the packages included in coalesce-core.