Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add array declarations to installer #1604

Merged

Conversation

fiammybe
Copy link
Member

This resolves the deprecated dynamic properties error during installation

fixes #1603

@fiammybe fiammybe added the bug label Dec 28, 2024
@fiammybe fiammybe added this to the 2.0.0 (new) milestone Dec 28, 2024
@fiammybe fiammybe requested review from MekDrop and skenow December 28, 2024 16:08
@fiammybe fiammybe self-assigned this Dec 28, 2024
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
Copy link
Contributor

@skenow skenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to go ahead and change all properties to be declared without using 'var'?

@fiammybe
Copy link
Member Author

I'll update the declarations to be more in line with newer PHP standards. That should placate codeclimate :-)

htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Outdated Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
htdocs/install/class/IcmsInstallWizard.php Show resolved Hide resolved
@fiammybe fiammybe merged commit 7909145 into ImpressCMS:2.0.x Dec 29, 2024
1 of 3 checks passed
@fiammybe fiammybe deleted the fix-installer-deprecated-dynamic-properties branch December 29, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix:IcmsInstallWizard $pagenames property is deprecated in PHP 8.4
2 participants