Convert to current global for $icmsModule #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sCMS#1593 The correct object is icms::$module
icms::$module is the proper object to use. See ImpressCMS#1593
…S#1593 Who's Online would not users active in modules Notifications would not show at all
There were some legacy code blocks that no longer are effective and just added to the overhead - removed those.]
…mpresscms.git into 2.0.x-globals-remapping
And doing some basic filtering on the $_POST variable
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| $notification_handler = icms::handler('icms_data_notification'); | ||
| // Now build the a nested associative array of info to pass | ||
| // to the block template. | ||
| $block = array(); | ||
| $categories = &$notification_handler->subscribableCategoryInfo(); | ||
| if (empty($categories)) { | ||
| return FALSE; | ||
| return false; |
There was a problem hiding this comment.
Returning type false but b_system_notification_show() is declared to return array
fiammybe
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression testing uncovered several core elements that needed adjustment after the change in the global for $icmsModule. This converts the remaining variable references and resolves #1593