language switcher refactoring

[fiammybe]

This gives the themes access to the different variables of the language switcher, in order to decide on the layout. Not really backwards compatible with old themes

[skenow]

This does work as intended. However, while testing I discovered that of the default values for the languages (English and German), the German language folder is not present, so only the label and link are present in the block (showing the English flag and the caption Deutsch). I suggest also changing the language constants _DEF_LANG_TAGS, _DEF_LANG_NAMES, _LOCAL_LANG_NAMES to have values of languages that are included in the core install

[fiammybe]

Wasn't it the rule to have the languages in their native description? Instead of 'German' it should be 'Deutsch' then. Similar for 'Nederlands' (Dutch) or 'Italiano' (you guessed it, Italian). On Sat, Sep 02, 2023 at 12:21am, Steve Kenow < ***@***.*** ***@***.*** > wrote: @skenow approved this pull request. This does work as intended. However, while testing I discovered that of the default values for the languages (English and German), the German language folder is not present, so only the label and link are present in the block (showing the English flag and the caption Deutsch). I suggest also changing the language constants _DEF_LANG_TAGS, _DEF_LANG_NAMES, _LOCAL_LANG_NAMES to have values of languages that are included in the core install — Reply to this email directly, view it on GitHub [#1496 (review)] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AA4QK4WYFPUBHK4M2P6CVG3XYJNWTANCNFSM6AAAAAA35RVQO4] . You are receiving this because you were assigned. Message ID: <ImpressCMS/impresscms/pull/1496/review/1607719239 @ github . com>

[skenow]

I think you could call it anything you wanted, as long as everything matched - the language folder, the flag icon, the name you use in the multi-language settings. All of the select boxes scan the language folder for the folders present and present them as they are named in the folder. Using native descriptions would be ideal