Move analytics code to preload #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my tests, the ['async'] attribute is not rendered with this - I had to use ['async' => 'async'], which is valid notation for the script. Our code also inserts type=text/javascript into the script signature. Not a big deal. |
changed 'async' => 'async'
|
updated the 'async' => 'async' and making it ready for review |
skenow
requested changes
Mar 18, 2023
skenow
reviewed
Mar 18, 2023
skenow
reviewed
Jun 17, 2023
skenow
approved these changes
Aug 13, 2023
skenow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the UA code to the preload. This code also looks for the value of the Google Analytics tag and decides based on that whether to add the old UA or the new GA4 script