-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the jupyter kernelspec setup #247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #247 +/- ##
========================================
Coverage 95.23% 95.23%
========================================
Files 28 28
Lines 1701 1701
========================================
Hits 1620 1620
Misses 81 81 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Just to note that this retains |
Description
This removes the redundant step of creating a specific
pyrealm_python3
kernel for Jupyter notebooks and falls back on thepoetry shell
andpoetry run
commands updating the Jupyter kernel specs when run.I have also added
jupytext --pipe black
as apre-commit
hook on thedocs/source
tree to add automaticblack
formatting of code cell contents, and also ensure consistent formatting of{code-cell}
directives (omits the default language)There is one downside of this, which is that
black
insists on stripping out semi-colons, which are a recognized (but hacky) way to suppress the printing ofmatplotlib
function return values.Fixes #246
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks