Adds the new report model #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Bland <t.bland@imperial.ac.uk>
Adds the new Measurement model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #115
To be reviewed and merged after #128
Ads the new Report model, inheriting from
MeasurementBase(see #128 ), including the report type, flags to indicate when it has been used and validation.For the tests, the package
model_bakeryhas been added, and the CI the workflow file has been updated accordingly. I've also added this to the Dockerfile as we are in the development phase. Ideally, we will want to get rid of it in production, so the image do not include unnecessary packages, but it should be ok for now.