Skip to content

Commit

Permalink
debug
Browse files Browse the repository at this point in the history
  • Loading branch information
barneydobson committed Nov 1, 2024
1 parent 07df823 commit 5e72d02
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 10 deletions.
Binary file added docs/paper/extended_demo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion docs/paper/extended_demo.svg

This file was deleted.

12 changes: 4 additions & 8 deletions docs/paper/paper.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,13 @@ tags:
- swmm
- hydraulic-modelling
authors:
- family-names: "Dobson"
given-names: "Barnaby"
- name: "Barnaby Dobson"
orcid: "https://orcid.org/0000-0002-0149-4124"
affiliation: 1
- family-names: "Alonso-Álvarez"
given-names: "Diego"
- name: "Diego Alonso-Álvarez"
orcid: "https://orcid.org/0000-0002-0060-9495"
affiliation: 1
- family-names: "Chegini"
given-names: "Taher"
- name: "Taher Chegini"
orcid: "https://orcid.org/0000-0002-5430-6000"
affiliation: 2
affiliations:
Expand All @@ -27,7 +24,6 @@ affiliations:
index: 2
date: 16 October 2024
bibliography: paper.bib

---

## Summary
Expand Down Expand Up @@ -58,7 +54,7 @@ The core task in SWMManywhere is to begin with a 'starting graph' (e.g., an OSM

We visualise the example from the [extended demonstration](https://imperialcollegelondon.github.io/SWMManywhere/notebooks/extended_demo/) in the documentation to illustrate how changing relatively few parameter values in a strategic way can dramatically change the nature of the synthesised network \autoref{fig:fig1}.

![Figure 1: Example of output customisation with SWMManywhere. Black nodes are manholes, black lines are pipes, red nodes are outfalls.\label{fig:fig1}](extended_demo.svg)
![Figure 1: Example of output customisation with SWMManywhere. Black nodes are manholes, black lines are pipes, red nodes are outfalls.\label{fig:fig1}](extended_demo.png)

## Outlook

Expand Down
2 changes: 1 addition & 1 deletion src/swmmanywhere/graph_utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def save_graph(G: nx.Graph, fid: Path) -> None:
G (nx.Graph): A graph
fid (Path): The path to the file
"""
json_data = nx.node_link_data(G, edges="edges")
json_data = nx.node_link_data(G, edges="links")

with fid.open("w") as file:
json.dump(json_data, file, default=_serialize_line_string)
Expand Down

0 comments on commit 5e72d02

Please sign in to comment.