dict: embed item structs in hash entries #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of duplicating an item struct's fields in the hash entry struct that wraps it, add the entire item struct as a field of the hash entry. This eliminates casts and ensures the type system understands what we're doing. Fixes strict aliasing violations in dcm_init(): we were assigning through a cast and then immediately reading through the original pointer. This happened to cause segfaults on RHEL 9 aarch64, but any compiler would be entitled to optimize away the read.
Clarify that they're not _hash_entry structs.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating an item struct's fields in the hash entry struct that wraps it, add the entire item struct as a field of the hash entry. This eliminates casts and ensures the type system understands what we're doing.
Fixes strict aliasing violations in
dcm_init(): we were assigning through a cast and then immediately reading through the original pointer. This happened to cause segfaults on RHEL 9 aarch64, but any compiler would be entitled to optimize away the read.Also rename some variables to clarify that they're not
_hash_entrystructs.