Only use __attribute__((constructor)) if supported
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HAS_CONSTRUCTOR check didn't do anything, since we tried to use __attribute__((constructor)) whether it was defined or not. That caused a build failure on MSVC. Also, we shouldn't add the constructor attribute from a public header, since it's only relevant while building the library, and is conditioned on a config.h macro that isn't visible outside the library. Move constructor handling directly to the one call site that needs it.
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HAS_CONSTRUCTORcheck didn't do anything, since we tried to use__attribute__((constructor))whether it was defined or not. That caused a build failure on MSVC.Also, we shouldn't add the constructor attribute from a public header, since it's only relevant while building the library, and is conditioned on a
config.hmacro that isn't visible outside the library. Move constructor handling directly to the one call site that needs it.While we're here, simplify the constructor support check in
meson.build.