Use a generator to get bytes of pydicom.Datasets
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `store_instances` of `DICOMwebClient`. The `store_instances` method accepts a set of DICOM frames, dumps them to bytes, and, finally, encodes them into a multipart/related request. The above process results in storing the original DICOM frames in memory 3 times: 1. as the original `pydicom.Dataset` instances passed into `store_instances` 2. as bytes encoded in `store_instances` 3. as the concatenation of the above bytes created in `_encode_multipart_message` Using a generator in `store_instances` reduces memory footprint by 1/3, since the original `pydicom.Dataset`s are dumped into bytes one by one while the multipart request body is being created by `_encode_multipart_message`.
adamvonpaternos
approved these changes
Feb 18, 2023
|
Thanks for your contribution @pchristos. Much appreciated. We will draft a new release and make a new version of the package available via pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
store_instancesofDICOMwebClient.The
store_instancesmethod accepts a set of DICOM frames, dumps them to bytes, and, finally, encodes them into a multipart/related request.The above process results in storing the original DICOM frames in memory 3 times:
pydicom.Datasetinstances passed intostore_instancesstore_instances_encode_multipart_messageUsing a generator in
store_instancesreduces memory footprint by 1/3, since the originalpydicom.Datasets are dumped into bytes one by one while the multipart request body is being created by_encode_multipart_message.