Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On line example site doesn't work #55

Open
yliu7366 opened this issue Jun 2, 2021 · 8 comments
Open

On line example site doesn't work #55

yliu7366 opened this issue Jun 2, 2021 · 8 comments
Labels
examples not working Online demo examples are not working

Comments

@yliu7366
Copy link

yliu7366 commented Jun 2, 2021

The on line example website (https://microscopy.dcmjs.org/) doesn't display WSIs and shows white blank pages.

@hackermd hackermd added the examples not working Online demo examples are not working label Jun 4, 2021
@hackermd
Copy link
Collaborator

hackermd commented Jun 4, 2021

Thank you @yliu7366 for reporting the issue. The seems the examples have not been updated server-side. @pieper @swederik @Punzo @igoroctaviano do you have any insight into why the examples are not up-to-date on the server?

@Punzo
Copy link
Contributor

Punzo commented Jun 4, 2021

I don't have access to the server, maybe Igor, Erik for sure.

@swederik are the examples being deployed automatically in https://microscopy.dcmjs.org/ when a release is done (we are currently at version 0.30.1 and the examples are probably at version ~0.20)? or is something that we need to start manually?

@igoroctaviano
Copy link
Collaborator

Screen Shot 2021-06-04 at 14 18 29

I'm not sure why but for sure something is wrong with this latest deployed example site.

@swederik
Copy link
Contributor

swederik commented Jun 4, 2021

Is it not using the es5 output? Otherwise you could try providing it with the module tag in the <script> link?

@Sledzik
Copy link

Sledzik commented Jun 16, 2021

How can I quickly check features if the online examples don't work?

@hackermd
Copy link
Collaborator

The examples also don't work locally when using <script src="https://unpkg.com/dicom-microscopy-viewer"></script>. However, they work when using <script src="../../build/dicom-microscopy-viewer.js">.

@hackermd
Copy link
Collaborator

How can I quickly check features if the online examples don't work?

@Sledzik you can check locally, instructing <script>...</script> to use the locally built bundle (see above #55 (comment)).

@Punzo
Copy link
Contributor

Punzo commented Jun 16, 2021

https://github.com/MGHComputationalPathology/dicom-microscopy-viewer/blob/master/examples/blend/index.html#L23-L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples not working Online demo examples are not working
Projects
None yet
Development

No branches or pull requests

6 participants