USD PrimitiveAlgo : Fix loading of facevarying skinned normals #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really know what these USD functions do, but looks reasonable, and I assume you've tested it. |
The remapping discussed appears to be performed for us inside `UsdSkelSkinningQuery::ComputeSkinnedPoints()` and `UsdSkelSkinningQuery::ComputeSkinnedNormals()`, as well as in our new facevarying normals code. That would explain why an attempt to apply it manually would lead to things getting jumbled up.
johnhaddon
force-pushed
the
facevaryingNormalSkinning
branch
from
2e1cef1
to
fd80130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.