USD ShaderAlgo : Improve shader type heuristics #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us round-trip the `Shader::getType()` for Arnold lights, which is necessary for Gaffer features like visualisations and the LightTool.
murraystevenson
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Heuristic looks reasonable to me. Arnold does have a visible_light shader that would be classified incorrectly here, but that shader seems like an internal detail as it's not documented anywhere I can find and isn't usable in Gaffer as it requires specifying a POINTER to a light...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us round-trip the
Shader::getType()for Arnold lights, which is necessary for Gaffer features like visualisations and the LightTool.This is nasty stuff really, and in the long term we just want to stop using shader types completely. We need the fix here in the short term because the longer term fix in Gaffer (not using the type at all) requires an ABI break, and isn't suitable for release in Gaffer 1.3. I intend to do that work next though, so things are moving in the right direction for 1.4.