IECore.repr() should not be locale-sensitive
#1338
Comments
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this issue
Feb 20, 2023
I removed this in e323014 after verifying that the OCIO bug it worked around was now fixed properly. But what I didn't realise is that we have our _own_ equivalent bug in ImageEngine/cortex#1338. So I'm reverting the change until we have time to fix properly in Cortex. Fixed GafferHQ#5158
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this issue
Feb 20, 2023
I removed this in e323014 after verifying that the OCIO bug it worked around was now fixed properly. But what I didn't realise is that we have our _own_ equivalent bug in ImageEngine/cortex#1338. So I'm reverting the change until we have time to fix properly in Cortex. Fixes GafferHQ#5158
This was referenced Feb 20, 2023
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this issue
Feb 24, 2023
I removed this in e323014 after verifying that the OCIO bug it worked around was now fixed properly. But what I didn't realise is that we have our _own_ equivalent bug in ImageEngine/cortex#1338. So I'm reverting the change until we have time to fix properly in Cortex. Fixes GafferHQ#5158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
IECore.repr()is usingboost::lexical_castunder the hood, which is locale sensitive. In some locales, this means the result cannot be parsed by Python.Steps to Reproduce
Run
python -c "import locale; locale.setlocale( locale.LC_NUMERIC, 'fr_FR.UTF-8' ); import IECore; import imath; print( IECore.repr( imath.V2f( 1.25 ) ) )This outputs
imath.V2f( 1,25, 1,25 )but should outputimath.V2f( 1.25, 1.25 )Recommended solution
Reimplement
IECore::repr()usingfmt::format(), which is fast, and ignores locale unless explicitly requested.The text was updated successfully, but these errors were encountered: