Updated popup.html and style.css #64
Conversation
|
New PR following some doubts made in the failed PR. |
| .power-switch { | ||
| margin: 3px; | ||
| } | ||
|
|
There was a problem hiding this comment.
these changes will only bloat the css file and slow down loading.
There was a problem hiding this comment.
I just removed it from the html and added it to the css, but we can remove it.
There was a problem hiding this comment.
I just removed it from the html and added it to the css, but we can remove it.
it just makes sense to keep it inline as this way it loads faster as inline CSS is directly available
There was a problem hiding this comment.
If you remove this margin, it will put the item on the red line
There was a problem hiding this comment.
If you remove this margin, it will put the item on the red line
I never suggested removing it?
There was a problem hiding this comment.
I decided to remove the css in the html to make your html file more clean, since using styles.css in the project.
but inline CSS allows for faster load speeds
There was a problem hiding this comment.
In your project, impact is not considered, so overloading doesn't make sense to me. There are other techniques to minify your css.
There was a problem hiding this comment.
example: https://www.cleancss.com/css-minify
There was a problem hiding this comment.
In your project, impact is not considered, so overloading doesn't make sense to me. There are other techniques to minify your css.
I realise that but I don't see this to be necessary?
There was a problem hiding this comment.
A legal document about
https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Organizing
Follow my suggestion again without lint enabled.
We remove styles in html
We added some styles in styles.css
I hope now you don't consider this as spam =)