This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Filter bad-cigar reads in bam streamer #288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These reads are ok according to SAM/BAM spec, but Manta can't work with them
|
We have tested this change on 100 cases and all output was identical to the original workaround using awk to filter alignments before calling manta. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These reads are ok according to SAM/BAM spec, but Manta can't work with them.
This fixes issue #137 "Manta crashes on input files realigned with ABRA #137"
as well as issue #184 "Unclear how to deal with CIGAR strings with InDels at the end of reads"
The fix is to remove offending alignments in the bam streamer instead of throwing an exception much later in the code. This has the same effect as pre-filtering the alignments using awk (as described in issue 184), but it is much faster.