Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display toolbox name #343

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

jazzsnobeatcake
Copy link
Contributor

Description

Displays the toolbox name instead of the word toolbox.

Motivation and Context

$hostname defaults to "toolbox" when inside a toolbox.
$tide_toolbox_icon already indicates we're in a toolbox.
Displaying the toolbox name adds further context in multi-toolbox environments.

Screenshots (if appropriate)

How Has This Been Tested

I tested this on Fedora Silverblue 36

  • I have tested using Linux.
  • I have tested using MacOS.

Checklist

Unsure if these are applicable.

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Displays the toolbox name instead of the word toolbox.
$tide_toolbox_icon already indicates we're in a toolbox, displaying the toolbox name adds further context in multi-toolbox environments.
@daudix
Copy link
Contributor

daudix commented Sep 14, 2022

This would be really useful 👍

@IlanCosman
Copy link
Owner

Hi, sorry for the delay on reviewing this. I haven't had access to a linux machine for a while, but will again soon.

@IlanCosman
Copy link
Owner

IlanCosman commented Sep 14, 2022

Also, external commands like sed, awk, and cat should be replaced with fish builtins such as string match, string replace, and redirection (some_command <file.txt). Makes the code much faster and more portable :)

@IlanCosman IlanCosman merged commit e8b2443 into IlanCosman:main Sep 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants