Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual environment indicator removed if only python3 installed #162

Closed
GregDMeyer opened this issue Jun 3, 2021 · 1 comment
Closed
Labels
🐛 bug Something isn't working
Milestone

Comments

@GregDMeyer
Copy link

Describe the bug

If there is no command python present on the system, but Python 3 is installed (e.g. by default on recent Ubuntu distros), the virtual environment item is removed from the prompt.

Steps to reproduce

  1. Run a machine that has only python3 but not python available
  2. Generate a virtual environment with python3 -m venv test_env
  3. Run source test_env/bin/activate.fish
  4. Virtual environment indicator is not present on the right hand side of prompt

Environment

Output of tide bug-report:

fish version: 3.2.2
tide version: 4.3.4
term: xterm-256color
os: Pop OS 20.10
terminal emulator: Gnome terminal

Additional context

I did a tiny bit of digging and it looks like the function _tide_remove_unusable_items removes the virtual_env item if the command python is not present (it does not check if python3 etc. may be available instead).

@GregDMeyer GregDMeyer added the 🐛 bug Something isn't working label Jun 3, 2021
@IlanCosman
Copy link
Owner

Nice catch!

@IlanCosman IlanCosman added this to the v5.0.0 milestone Jun 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants