Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed bug with Finished Condition during background tasks #957

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

Jacob-Tate
Copy link
Contributor

There is a bug in the following condition:

  • Import a manga and place it into a collection without downloading metadata
  • Perform background tasks

This will result in the manga being marked as finished due to the episode count being 0. Modifying the condition to ensure that we arent marking something as finished without any watch history addresses this problem. This issue is extremely prevalent in the Sync to Owned collection function.

@IgnisDa IgnisDa merged commit b1c1069 into IgnisDa:main Aug 11, 2024
1 check passed
@Jacob-Tate Jacob-Tate deleted the fix_finished_condition branch August 11, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants