-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing "ps" terminal command on app crash/exit #944
Conversation
Fixes errors with invocations of "ps" terminal command
Can you tell me how to reproduce the issue? The particular error you are getting comes from concurrently killing the frontend if the backend dies. So that error is expected. |
In my case I caused the state when app wasn't able to launch like specified TZ with typo. I suspect it would throw this error always for any state when backend doesn't start or when it crashes and based on error it invokes "ps" command but it doesn't exist (not installed in os). With ps installed the shutdown hook executes gracefully without this extra error that likely will mislead end user. |
Makes sense. I will merge this once #939 is merged since that will introduce conflicts. |
Thanks for the contribution! |
* ci: add cross-rs build * add missing env * add env file * add build frontend * use moonrepo setup toolchain * use moon docker * delete docker setup * add artifact path * download templates * add path * add path * add ls * add templates * use abs * typo * rename artifact * add build docker * env permission * add ghcr * add libssl * openssl * remove curl * add tar * add path * cd * --strip-components * cd * apps/frontend/ * build frontend twice * remove debug assertion * build on host * sudo * arm64 * arm64 * libssl * rustup * ci: add new token * set env * Revert "build on host" This reverts commit a47df4e. * install libssl1.1 for arm64 * lint * typo * typo * sh not bash * y * docker tag * cache when not in a pull request * delete old files * enable * passenv * re-add the change from #944 * ci: change name of file * ci: decide whether to run workflow in PR * ci: test commit Run CI. * ci: test commit Run CI. * ci: Run CI * ci: dump contents [Run CI] * ci: add more logging [RUN CI] * ci: select correct commit message [Run CI] * ci: remove useless comment * ci: add caching to docker action * ci: test whole commit message if workflow should run Run CI. * also push to docker hub * typo [Run CI] * ci: enable dockerhub only for main releases * ci: remove useless echo statements [Run CI] * use repository_owner [Run CI] * ci: setup caching for building frontend * ci: build only in release mode [Run CI] * ci: add new steps * ci: change name of job [Run CI] * ci: change name of output * ci: add step to create release * ci: do not build frontend in gh action * ci: do not build transactional in dockerfile [Run CI] * ci: change name of step --------- Co-authored-by: Diptesh Choudhuri <ignisda2001@gmail.com>
Fixes errors with invocations of "ps" terminal command...
Current master/latest contains some code/libraries that invoke "ps" command under certain circumstances (perhaps specific architectures or such).
Example of error this meant to solve:
PS: it may not solve the problem of the core reason of why app itself crashed in my particular example, but it will allow app to handle shutdown gracefully in case of shutdown/crash flow.