Make "snabbvmx top" print out only counters that are defined #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #975 reported a bug in command
snabbvmx top
.One bug was related with a typo. Another was related with opening a non existing counter.
The issue was that
snabbvmx
top attempted to openin-ipv4-frag-reassembled
but that counter didn't exist on/var/run/snabb/PID/apps/lwaftr/counters
. I modifiedsnabbvmx top
to handle the case when tries to open a counter that is not defined.I think the former code was working before because all counters were created regardless they were being used or not, but now it's not the case.
Fixes #975.