Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "snabbvmx top" print out only counters that are defined #998

Merged
merged 2 commits into from
Nov 6, 2017

Conversation

dpino
Copy link
Member

@dpino dpino commented Nov 2, 2017

Issue #975 reported a bug in command snabbvmx top.

One bug was related with a typo. Another was related with opening a non existing counter.

The issue was that snabbvmx top attempted to open in-ipv4-frag-reassembled but that counter didn't exist on /var/run/snabb/PID/apps/lwaftr/counters. I modified snabbvmx topto handle the case when tries to open a counter that is not defined.

I think the former code was working before because all counters were created regardless they were being used or not, but now it's not the case.

Fixes #975.

@dpino dpino changed the title Fix typo in require Snabbvmx top should only print out counters that are defined Nov 2, 2017
@dpino dpino changed the title Snabbvmx top should only print out counters that are defined Make "snabbvmx top" print out only counters that are defined Nov 2, 2017
@dpino
Copy link
Member Author

dpino commented Nov 2, 2017

Running instance:

lwaftr (rx/tx/txdrop in Mpps)                       rx      tx      rxGb    txGb    txdrop
 lwaftr_v6                                           0.16    0.16    0.72    0.78    0.162993
 lwaftr_v4                                           0.16    0.16    0.72    0.75    0.162993

                                                                   Total           per second
 lwaftr_v6 in-ipv6-packets                                     1,679,096              163,200
 lwaftr_v6 in-ipv6-bytes                                     923,502,800           89,760,000
 lwaftr_v6 out-ipv6-packets                                    1,679,096              163,200
 lwaftr_v6 out-ipv6-bytes                                  1,004,099,408           97,593,600
 lwaftr_v6 drop-all-ipv6-iface-packets                         1,679,096              163,200

                                                                   Total           per second
 nic ifInDiscards                                                      0                    0

                                                                   Total           per second
 lwaftr_v4 in-ipv4-packets                                     1,760,901              163,200
 lwaftr_v4 in-ipv4-bytes                                     968,495,550           89,760,000
 lwaftr_v4 out-ipv4-packets                                    1,760,901              163,200
 lwaftr_v4 out-ipv4-bytes                                  1,017,800,778           94,329,600
 lwaftr_v4 drop-all-ipv4-iface-packets                         1,760,901              163,200

@dpino dpino merged commit 52bf472 into lwaftr Nov 6, 2017
@dpino dpino deleted the fix-issue-975 branch November 6, 2017 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants