Fix ARP and NDP next-hop detection with RSS #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shared_next_mac_key to ARP configuration to allow workers behind RSS to share next-hop information.
Add shared_next_mac_key to NDP configuration to allow workers behind RSS to share next-hop information.
Hopefully fixes #981.
takikawa
reviewed
Sep 28, 2017
src/apps/ipv4/arp.lua
Outdated
| print(("ARP: '%s' resolved (%s)"):format(ipv4:ntop(ip), ethernet:ntop(mac))) | ||
| if self.alarm_notification then | ||
| resolve_alarm:clear() | ||
| end | ||
| self.next_mac = mac | ||
| if self.shared_next_mac_key then | ||
| local ok, shared_mac = pcall(shm.create, self.shared_next_mac_key, mac_t) |
There was a problem hiding this comment.
Does shared_mac need to be shm.unmaped at the end of the block or is it ok to leave it?
takikawa
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #981 by having the ARP app that receives an ARP response write that MAC to shared memory. Likewise for NDP. When apps are still resolving addresses, they will try to read from a shared file also.