forked from snabbco/snabb
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver independence #949
Merged
Merged
Driver independence #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove specifications of this parameter that are just the default value.
I have tested this on |
Also, allow any PCI device with a driver.
Also use ring_buffer_size driver initarg to set ring buffer size.
Otherwise the MAC address is not stamped on outgoing packets. See snabbco#749.
Otherwise MAC filtering will not work. Also, intel_mp carps if there is a MAC address set but vmdq is false. See snabbco#749 for full details.
Point to intel_mp for the Intel driver.
The ingress drop monitor used to poll apps with an "ingress_packet_drops" function, but the intel_mp app names this function "rxdrop". "rxdrop" is much more succinct and captures the meaning, so let's use that instead. Change intel10g to use the new "rxdrop" name, and update the lwaftr loadtest.
fce48ad
to
7323d37
Compare
dpino
approved these changes
Sep 20, 2017
The build failure appears to be a flaky property-based test, unrelated to the contents of this patch. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of snabbco#1234 to
lwaftr
, resolving a minor conflict insnabbvmx
'ssetup.lua
.