Decouple alarms declaration #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpino
force-pushed
the
decouple-alarms-declaration
branch
from
da4ee68 to
9321ef6
Compare
dpino
force-pushed
the
decouple-alarms-declaration
branch
from
9321ef6 to
6643388
Compare
wingo
approved these changes
Sep 19, 2017
src/apps/ipv4/arp.lua
Outdated
| 'address of the next-hop directly. To do it so, set '.. | ||
| 'external-interface.next-hop.mac to the value of the MAC address.', | ||
| }, | ||
| alarm_text = 'Make sure you can ARP resolve IP addresses on NIC', |
src/apps/lwaftr/alarms.lua
Outdated
| @@ -0,0 +1,25 @@ | |||
| module(..., package.seeall) | |||
There was a problem hiding this comment.
Perhaps place in program/lwaftr ? I mean, it's more about the lwaftr network function as a whole and not the apps. Dunno tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #925.
Alarms are declared throughout the codebase, usually within the module that uses the alarm. The alarm declaration defines its involved resources, alarm-type-id and alarm-qualifier for the alarm. In the case of the ARP and NDP alarms, the resource was named after a feature of the lwAFTR. The naming should be decoupled. In addition, the
alarm_textmessage to help the operator to fix the issue also refer to the internals of the lwAFTR. This should be decoupled too.To better refine alarms for the lwAFTR, this PR defines an apps.lwaftr.alarms module that uses the alarms API to overwrite an existing alarm. When
declare_alarmfinds an alarm has already been declared, it overwrites its values or adds new ones. This way we can reuse existing alarms and customize messages (or other attributes) for the lwAFTR.