Deprecate reconfigurable flag #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsyesika
force-pushed
the
deprecate-reconfigurable-flag
branch
from
5cb11b1 to
176906c
Compare
wingo
approved these changes
Aug 15, 2017
src/program/lwaftr/bench/bench.lua
Outdated
| @@ -31,7 +31,9 @@ function parse_args(args) | |||
| function handlers.b(arg) opts.bench_file = arg end | |||
| function handlers.y() opts.hydra = true end | |||
| function handlers.h() show_usage(0) end | |||
| function handlers.reconfigurable() opts.reconfigurable = true end | |||
| function handlers.reconfigurable() | |||
| io.stderr:write("Warning: --reconfigurable flag has been deprecated.\n") | |||
There was a problem hiding this comment.
Let's remove this one entirely, as this is an internal script that's not user-facing.
src/program/lwaftr/run/run.lua
Outdated
| @@ -102,7 +102,9 @@ function parse_args(args) | |||
| .." (valid values: flush, warn, off)") | |||
| end | |||
| end | |||
| function handlers.reconfigurable() opts.reconfigurable = true end | |||
| function handlers.reconfigurable() | |||
| io.stderr:write("Warning: --reconfigurable flag has been deprecated.\n") | |||
There was a problem hiding this comment.
Can we adapt this note to somehow assure the user that --reconfigurable is always enabled so they can safely remove the flag from their scripts? This note says that it's deprecated but not what action they need to take.
tsyesika
force-pushed
the
deprecate-reconfigurable-flag
branch
from
8d855fd to
95c1e4e
Compare
wingo
approved these changes
Aug 15, 2017
added 2 commits
August 15, 2017 14:12
This deprecates the --reconfigurable flag from all lwaftr apps. The reconfigurable / multiprocess mode is always enabled. The tests have been simplied to reflect this. A deprecation warning is shown if --reconfigurable is used. As of this change, ingress drop monitor is no longer supported. An issue tracking the support is #902. A warning is shown if it is used.
This removes the --reconfigurable flag in the bench command entirely as it's internal facing. It also improves the message in the deprecation warning in the run command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the
--reconfigurableflag in favour of having it always be in a multi-process re-configurable mode. The use of the flag will now raise a deprecation warning.One other thing to note is as of this PR the ingress drop monitor support is no longer available as documented in #902.