-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ietf-softwire schema with new ietf-softwire-br #1000
Conversation
As agreed with Ian Farrer.
This is an incompatible change, but one which users have asked for. So it goes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Few questions/nits.
local key_t = data.typeof(grammar.key_ctype) | ||
return cltable.new({key_type=key_t}), key_t | ||
end | ||
|
||
local function ietf_binding_table_from_native(bt) | ||
local ret, key_t = cltable_for_grammar(get_ietf_softwire_grammar()) | ||
local psid_key_t = data.typeof('struct { uint32_t ipv4; }') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is used. Maybe it can be removed.
@@ -339,10 +365,10 @@ local function ietf_softwire_translator () | |||
end | |||
return true | |||
end | |||
-- Re-start here tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this still be here?
This commit sets
ietf-softwire-br
as the default Snabb lwAFTR yang schema, replacing the formerietf-softwire
translator.