Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ietf-softwire schema with new ietf-softwire-br #1000

Merged
merged 7 commits into from
Nov 8, 2017

Conversation

wingo
Copy link

@wingo wingo commented Nov 7, 2017

This commit sets ietf-softwire-br as the default Snabb lwAFTR yang schema, replacing the former ietf-softwire translator.

Copy link

@tsyesika tsyesika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Few questions/nits.

local key_t = data.typeof(grammar.key_ctype)
return cltable.new({key_type=key_t}), key_t
end

local function ietf_binding_table_from_native(bt)
local ret, key_t = cltable_for_grammar(get_ietf_softwire_grammar())
local psid_key_t = data.typeof('struct { uint32_t ipv4; }')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is used. Maybe it can be removed.

@@ -339,10 +365,10 @@ local function ietf_softwire_translator ()
end
return true
end
-- Re-start here tomorrow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be here?

@wingo wingo merged commit 9d81c03 into lwaftr Nov 8, 2017
@wingo wingo deleted the ietf-softwire-br branch November 8, 2017 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants