Support tmux #38
Merged
Support tmux #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supporting tmux required updating to the latest cview (v1.5.7) which drew in changes in tcell. In this commit we also move to cview's new repo, and finally remove the import alias which aliased cview to tview. Most the changes in `internal/gui` are what was required to compile cave-logger on this newer cview, as there have been several breaking API changes. The most affecting being the removinal of chaining. While Trevor had good reasons for this it was a functionality that cave-logger used extensively. Also remove unused channel from page structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting tmux required updating to the latest cview (v1.5.7) which
drew in changes in tcell.
In this commit we also move to cview's new repo, and finally remove the
import alias which aliased cview to tview.
Most the changes in
internal/guiare what was required to compilecave-logger on this newer cview, as there have been several breaking API
changes. The most affecting being the removinal of chaining. While
Trevor had good reasons for this it was a functionality that cave-logger
used extensively.
Also remove unused channel from page structs.