Replace the name callable with function. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohe
requested review from
ctriant and
peppelinux
and removed request for
ctriant
|
It's not affecting the functionality so it's LGTM |
ctriant
approved these changes
Apr 21, 2023
|
@ctriant This will mean that you will have to modify your PR once this PR is part of the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had
functionandclassused for different types of callable in the configuration.I don't think we need a third one (
callable) if there is no significant difference between it and the other two.So I have done a refactoring replacing all occurrences of
callablewithfunction.