This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix calculation of epoch that is not taking into account the timezone #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that
datetime(1970, 1, 1)
does not include a timezone component and it is assumed to be a local date.The reason for this is because my localtime is not UTC, but "Europe/Athens".
If my timezone was UTC, then this would look as expected:
The right thing to do is to have an explicit timezone component on the date object
Calculations against that object would yield correct results.
However, it is not needed to do such a calculation "by hand", as the standard library provides the tools to convert a
datetime
object to a timestampSo, instead of calculating the timestamp by creating a delta between two dates (which must be on the same timezone) and converting the result to seconds, we can just get the timestamp by calling
.timestamp()
on the datetime object. The timestamp will be relative to the datetime object timezone, which we must ensure is always on UTC.