Preserve object_type for new objects while triggering a SyncRule
#2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `object_type` while preparing new objects was set to `object` without checking whether the `object_type` property of the corresponding objects had been set. Hence, the notifications or other objects with `object_type` `apply` was not working.
|
Thanks for this PR! I tried to reproduce the problem - this doesn't seem to fix it |
|
Hi @raviks789, I pushed a different solution for this one. Could you please test, whether it addresses your issue? Thanks, |
Thomas-Gelf
added a commit
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
object_typewhile preparing new objects was set toobjectwithout checking whether theobject_typeproperty of the corresponding objects had been set. Hence, the notifications or other objects withobject_typeapplywas not working.fixes #2142