Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases when gipfl/linux-health returns false instead of memory … #2544

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

trukonsult
Copy link
Contributor

The module gipfl/linux-health, which Directory uses to read memory usage for the background daemon, returns false if the system doesn't have a /proc-filesystem. This causes the WebUI to fail with an error. This patch allows the WebUI to work and instead shows "n/a" for memory usage in such case.

@cla-bot
Copy link

cla-bot bot commented Jun 2, 2022

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @trukonsult

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

bobapple commented Jun 3, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Jun 3, 2022
@Thomas-Gelf Thomas-Gelf added this to the 1.10.0 milestone Jun 24, 2022
@Thomas-Gelf Thomas-Gelf merged commit 4b229c1 into Icinga:master Jun 24, 2022
@Thomas-Gelf
Copy link
Contributor

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants