Fix restoring director job from snapshot for import source and sync rule #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule. Remove rule_id and source_id from the SyncJob and ImportJob settings respectively. Use rule_name and source_name to obtain the list of rules or sources respectively. In other terms avoid using rule_id or source_id entirely in settings.
raviks789
force-pushed
the
fix/restore-director-job
branch
from
4218178
to
4209576
Compare
|
Thank you Ravi, has been merged with a small modification (unsetting source/rule after setting the ID on restore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import source and sync rule ids are added to to director job settings before import as they are not present in the snapshot.
ref/IP/38986