Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty activity log causes exception refs #2505 #2506

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

moreamazingnick
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla/signed label Mar 28, 2022
Copy link
Contributor

@Thomas-Gelf Thomas-Gelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me, please fix the syntax as shown (phpcs should not complain) and amend/squash/force-push/whatever :-)

@@ -62,6 +62,9 @@ protected function fetchQueryRows()
{
$rows = parent::fetchQueryRows();
// Hint -> DESC, that's why they are inverted
if( empty($rows)){
Copy link
Contributor

@Thomas-Gelf Thomas-Gelf Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (empty($rows)) {

@Thomas-Gelf Thomas-Gelf merged commit 83cc129 into Icinga:master Mar 28, 2022
@Thomas-Gelf Thomas-Gelf added this to the 1.9.1 milestone Mar 28, 2022
@Thomas-Gelf
Copy link
Contributor

Merged, thank you!

Thomas-Gelf pushed a commit that referenced this pull request Apr 8, 2022
fixes #2505: empty activity log causes exception
fixes #2506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants