Restore services of service set on restoring service set.

[raviks789]

All the services which were under the service set when it was deleted must be restored when it is restored from activity log.

dependent on PR: #2418

fix #1065

[lippserd]

ref/IP/35863

[Thomas-Gelf]

Hi @raviks789,

thank you for this PR! Main problems:

• it doesn't work with PostgreSQL (can be fixed)
• it's a wild hack (per design, that's not your fault - it's a tricky task)

You correctly figured out, that related Service activities must have their Activity (Removal) Log somehow being triggered. I'd have had preferred a direct call to DirectorActivityLog::logRemoval() for each service - depending on a specific onDelete-Implementation is fragile.

But please let me propose a different implementation. The main issue here is how deletion takes place. A user issues a single operation ("Delete a Service Set"), but behind the scenes, multiple operations take place. For a better end user experience, this should be "one step" throughout the UI. Read: there should be only one entry in the Activity Log.

This sounds tricky, but the good news is: most of the related work has already been done. IcingaServiceSet implements the ExportInterface, and therefore has import/export-Methods. They're being used by our Configuration Baskets, and have one big advantage: no fiddling with IDs on restore. It is up to you to figure out, how this then fits into our current Show-Config-Diff-Implementation ;-)

Could you please give that approach a try? Only if you find the time of course, otherwise please let me know. I'm allowed to dedicate some time to similar tasks this week.

Thanks a lot,
Thomas

[Thomas-Gelf]

.

[tbauriedel]

ref/NC/732413

[nilmerg]

The export/import logic wasn't removed, only moved. (56f81b9) Isn't it still applicable here?

outdated