Add setmembers summyary line to TemplateUsageTable
#2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
changed the title
service_set_id is null condition to objects in ServiceTemplateU…service_set_id is null condition to objects in ServiceTemplateUsageTable.php
raviks789
force-pushed
the
fix/service-template-usage-table
branch
from
d4c2985
to
84682a8
Compare
raviks789
changed the title
service_set_id is null condition to objects in ServiceTemplateUsageTable.phpservice_set_id is null condition to objects in ObjectTableService.php
Thomas-Gelf
requested changes
Aug 19, 2021
There was a problem hiding this comment.
Hi @raviks789,
showing Services belonging to Service Sets in the "Single Services" list is not a fix for the problem you encountered. The problem is, that the "Usage summary" table doesn't provide a row for Service Templates used by Services in a Set.
ServiceTemplateUsageTable already shows a related (commented) section. However, this has been never been implemented. The following pieces are missing:
- a route/table showing you such services in a filtered way, together with der Service Set
- an extension to
TemplateUsageTable, allowing inheriting classes to tweak the underlying query
Best,
Thomas
|
NB: forget what I wrote about 'objects' => $this->getSummaryLine('object', 'o.service_set_id IS NULL'),To add Service Set members, use: 'setmembers' => $this->getSummaryLine('object', 'o.service_set_id IS NOT NULL'),Then it should look as follows:
To then complete the task, a quick attempt could be adding the possibility to filter the Service Set list by "used service template". |
raviks789
changed the title
service_set_id is null condition to objects in ObjectTableService.phpsetmembers summyary line to TemplateUsageTable
raviks789
force-pushed
the
fix/service-template-usage-table
branch
2 times, most recently
from
071ec41
to
1e86760
Compare
|
Cannot be merged yet:
|
raviks789
force-pushed
the
fix/service-template-usage-table
branch
3 times, most recently
from
15ba1f8
to
8f53620
Compare
raviks789
force-pushed
the
fix/service-template-usage-table
branch
4 times, most recently
from
4f354fe
to
6f27ffe
Compare
raviks789
force-pushed
the
fix/service-template-usage-table
branch
5 times, most recently
from
ee9a35f
to
b65b9d3
Compare
Thomas-Gelf
approved these changes
Sep 21, 2023
`'setmembers' => $this->getSummaryLine('object', 'o.service_set_id IS NOT NULL AND o.host_id IS NOT NULL'),` is added to TemplateUsageTable
and `objects` is set to ` $this->getSummaryLine('object', 'o.service_set_id IS NULL')`. Subsequently, ObjectTableSetMembers
is added which is used in `setmembersAction` in `TemplateController`. `ObjectTableSetMembers` uses service set name or service name
as search columns.
The host or service objects require retrieve the imports column. This makes it possible to filter them based on templates when a director branch is active.
…ches Icinga objects must be filterable based on templates when a director branch is active.
… branches` `TemplateUsageTable`, `ApplyRulesTable`, `ObjectsTableSetmembers` and `TemplatesTable` are made compatible with `director branches`.
Thomas-Gelf
force-pushed
the
fix/service-template-usage-table
branch
from
c15bd84
to
6b419b3
Compare
|
Merged, thank you! Disclaimer: I didn't test it at all ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services under service set is shown under
setmembersofTemplateUsageTable. And objects shows only services which do not belong to service set. This must solve the inconsistent number of objects problem.ref/IP/33703