Fix icinga_version to detect version without leading v/r

[kevin-olbrich]

CentOS 7:

[root@server121 ~]# icinga2 --version 2>/dev/null | grep version
icinga2 - The Icinga 2 network monitoring daemon (version: 2.11.0-1)
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl2.html>
  Platform version: 7 (Core)
  Kernel version: 4.4.193-1.el7.elrepo.x86_64

Debian 10:

root@slde0030 ~ # icinga2 --version 2>/dev/null | grep version
icinga2 - The Icinga 2 network monitoring daemon (version: r2.11.0-1)
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl2.html>
  Platform version: 10 (buster)
  Kernel version: 4.19.0-6-amd64

At least for CentOS, version is not prepended by "v" or "r".

[dnsmichi]

r and v should still be kept, they may re-occur. Also, older versions of Icinga don't work with this patch. Please see #1957 for a generic regex :-)

[kevin-olbrich]

r and v should still be kept, they may re-occur. Also, older versions of Icinga don't work with this patch. Please see #1957 for a generic regex :-)

You are right, I totaly missed that point :-)
The regex from #1957 still detects all other rows, shouldn't it be something like that to prevent it?:
'\(version: [rv]?\K\d+\.\d+\.\d+[^\)]*'

[dnsmichi]

Yep, it should but somehow the rest works in that script. I honestly don't understand the awk parts with the version compare. My PR was just a quickfix to allow a release soon-ish.

Maybe you can rebase your branch PR and apply the regex fix, force push the branch?

[kevin-olbrich]

Yep, it should but somehow the rest works in that script. I honestly don't understand the awk parts with the version compare. My PR was just a quickfix to allow a release soon-ish.

Maybe you can rebase your branch PR and apply the regex fix, force push the branch?

Done

[dnsmichi]

Related: https://community.icinga.com/t/icinga2-agent-kickstart-script-not-detecting-installed-icinga-version-on-client/2291/8

[Thomas-Gelf]

Thank you!