Ensure deployment logs are always collected #1878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially before running health checks.
|
@lazyfrosch: IMHO running a health check should trigger no action at all, without exemptions. The background daemon is going to be mandatory anyways with v1.7.0 - this can become one of it's first tasks. I'd love to finally remove this completely from the front-end. |
|
Created #1905, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially before running health checks.
Main problem with this was that for the user in UI, logs where only collected when reloading the deployment list.
If the user doesn't wait long enough, by switching to a different controller, the deployment stays stale.
Same can happen when the ConfigJob deploys, and the deployment does not finish within 3 seconds.
@Thomas-Gelf opinion?