Improve ActivityLog for services and servicesets #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazyfrosch
force-pushed
the
feature/activity-log
branch
from
4050fff
to
cb4c50e
Compare
This was mainly a problem for IcingaServiceSet and others that may have a capital letter where the table name is split by `_`
lazyfrosch
force-pushed
the
feature/activity-log
branch
from
cb4c50e
to
db00f1b
Compare
|
@Thomas-Gelf: Could you have a look at this? I'd be great to merge this soon. Should have no functional difference in terms of config, only activity log and visibility for diffs. |
lazyfrosch
changed the title
* A header is now always rendered and includes assign and description * Diff is now visible for sets
* Service to Host or ServiceSet * Set to Host
lazyfrosch
force-pushed
the
feature/activity-log
branch
from
5cac698
to
6d4475d
Compare
Thomas-Gelf
requested changes
Apr 10, 2019
There was a problem hiding this comment.
LGTM, thank you! Please address the phpcs complaint regarding the missing space on IcingaServiceSet.php:379 (https://travis-ci.org/Icinga/icingaweb2-module-director/jobs/518241290#L569), then this should be ready for merge
|
Wait I add one more change |
I didn't re-check the whole diff, but the phpcs complaint should be fixed. Nice, go! |
Thomas-Gelf
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assign_filter