Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for invalid basket content #2646

Closed
Thomas-Gelf opened this issue Oct 25, 2022 · 2 comments
Closed

Improve error messages for invalid basket content #2646

Thomas-Gelf opened this issue Oct 25, 2022 · 2 comments
Assignees
Milestone

Comments

@Thomas-Gelf
Copy link
Contributor

Expected Behavior

Errors related to invalid (binary) data should be easy to track down.

Current Behavior

When a basket cannot be encoded (read: transformed into JSON), this has historically been because of non-UTF8-characters (like binary UUIDs) slipping through. Such errors are hard to track down, as the message shows no hint pointing to the object causing this problem

Possible Solution

When an encoding error occurs, let's iterate over every single object, pick the first culprit one and enrich the message with related information.

@Thomas-Gelf Thomas-Gelf added this to the v1.10.2 milestone Oct 25, 2022
@Thomas-Gelf Thomas-Gelf self-assigned this Oct 25, 2022
Thomas-Gelf added a commit that referenced this issue Oct 25, 2022
...in case an error occurs at encoding time

fixes #2646
@Thomas-Gelf
Copy link
Contributor Author

image

@Thomas-Gelf
Copy link
Contributor Author

Formerly, this looked as follows:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant