Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Rule should remove variables set to NULL even in merge mode #2623

Closed
Thomas-Gelf opened this issue Sep 30, 2022 · 2 comments
Closed

Sync Rule should remove variables set to NULL even in merge mode #2623

Thomas-Gelf opened this issue Sep 30, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@Thomas-Gelf
Copy link
Contributor

Expected Behavior

When opting for the "merge" mode for a Sync Rule, only non-null source values are being applied. I do not consider this being the correct behavior, null from Sync should still "win" over an existing properties. Only properties which have not been defined in the Sync Rule should be preserved on the original object.

@jiri-lunacek
Copy link

Hello.

I do not consider this being the correct behavior, null from Sync should still "win" over an existing properties.

I strongly disagree with this thought.

We are extensively using the feature that null properties don't overwrite existing values.
Our properties mostly come from subkeys of json data from external source. In that case, when the key in json is not defined, it yields null in the property value, but giving this (non existent) value precedence makes no sense.

I think there should be a possibility to configure the precedence. Maybe by honoring Merge policy?
Replace - incoming null value has precedence
Merge - existing value is not replaced

@Thomas-Gelf
Copy link
Contributor Author

@jiri-lunacek: this initial fix had a problem, that has been fixed later on. Which version are you using, and could you please provide a simple example showcasing your issue? Anonymized JSON-Export for your Import Source (just 2-3 rows), and a Director Basket with the related Sync Rule definition would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants