Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Rule creates hostnames lowercase in v.1.10.0 #2608

Closed
phil-or opened this issue Sep 22, 2022 · 5 comments
Closed

Sync Rule creates hostnames lowercase in v.1.10.0 #2608

phil-or opened this issue Sep 22, 2022 · 5 comments
Assignees
@Thomas-Gelf
Labels
bug
Milestone
1.10.1

Comments

@phil-or
Copy link

phil-or commented Sep 22, 2022

Expected Behavior

Hostname should be synced as in Import-JSON File.

Current Behavior

In our Import JSON the hostnames are all uppercase.
After upgraded to v.1.10.0 the sync rule modified all hostnames from uppercase to lowercase.
I just updated the director module and dependencies. DB migration was also successful.
@Thomas-Gelf
Copy link
Contributor

Blind guess: undesired side-effect of #2598, this should not happen. I'll try to reproduce it

@Thomas-Gelf Thomas-Gelf self-assigned this Sep 22, 2022
@tbauriedel
Copy link
Member

ref/NC/764117

@Thomas-Gelf Thomas-Gelf added this to the 1.10.1 milestone Sep 22, 2022
@Thomas-Gelf
Copy link
Contributor

Should be fixed, could you please give it a try?

Thomas-Gelf added a commit that referenced this issue Sep 22, 2022
@Thomas-Gelf
Sync: create objects with original key...
121ce4d 
...and not with the lower-cased comparison key

fixes #2608
@phil-or
Copy link
Author

phil-or commented Sep 23, 2022

Master branch looks good.
Thanks!

@Thomas-Gelf
Copy link
Contributor

Thank you for letting me know! Has been cherry-picked to support/1.10 and will be released with v1.10.1

@Thomas-Gelf Thomas-Gelf mentioned this issue Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thomas-Gelf Thomas-Gelf

Labels
bug
Projects
None yet
Milestone
1.10.1
Development

No branches or pull requests
3 participants
@Thomas-Gelf @phil-or @tbauriedel