Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a centralized Exporter #2549

Closed
Thomas-Gelf opened this issue Jun 20, 2022 · 1 comment
Closed

Implement a centralized Exporter #2549

Thomas-Gelf opened this issue Jun 20, 2022 · 1 comment
Assignees
Milestone

Comments

@Thomas-Gelf
Copy link
Contributor

Export logic is distributed over existing objects, which renders export (baskets) hard to troubleshoot. First step: create a dedicated Exporter, collect all special cases in one place.

@Thomas-Gelf Thomas-Gelf self-assigned this Jun 20, 2022
Thomas-Gelf added a commit that referenced this issue Jun 20, 2022
refs #2549
Thomas-Gelf added a commit that referenced this issue Jun 24, 2022
refs #2549
@Thomas-Gelf Thomas-Gelf added this to the 1.10.0 milestone Jun 24, 2022
Thomas-Gelf added a commit that referenced this issue Jun 24, 2022
@Thomas-Gelf
Copy link
Contributor Author

Thomas-Gelf commented Jun 24, 2022

Tested with various objects, export is the same apart from the following differences:

  • originalId is no longer exported, it has shown to not be useful at all
  • all exported properties are now sorted, formerly some have not been
  • empty Job settings are now an empty dictionary (and not an array, which was technically not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant