Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve _override_servicevars on sync, even when replacing vars #1307

Closed
carraroj opened this issue Nov 28, 2017 · 3 comments
Closed

Preserve _override_servicevars on sync, even when replacing vars #1307

carraroj opened this issue Nov 28, 2017 · 3 comments
Assignees
@Thomas-Gelf
Milestone
1.5.0

Comments

@carraroj
Copy link

preserve _host_override when replacing vars.* on sync
@friesoft
Copy link
Contributor

The same applies to vars["_override_servicevars"]
Having a sync with merge strategy leads to entries from arrays not being deleted (even though they are gone in the import source).
Using replace they are correctly removed but the overriden variables are removed.

@widhalmt
Copy link
Member

+1 from me. This seems to hit a lot people.

@Thomas-Gelf Thomas-Gelf added this to the 1.5.0 milestone Feb 25, 2018
@phil-or
Copy link

phil-or commented Apr 26, 2018

+1

@Thomas-Gelf Thomas-Gelf self-assigned this May 4, 2018
@Thomas-Gelf Thomas-Gelf changed the title preserve _host_override when replacing vars Preserve _override_servicevars on sync, even when replacing vars May 4, 2018
bargru pushed a commit to bargru/icingaweb2-module-director that referenced this issue Jun 12, 2018
@Thomas-Gelf
Sync: preserve _override_servicevars
5d8ea97 
fixes Icinga#1307

Signed-off-by: Barnim Grüneberg  <13362393+bargru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thomas-Gelf Thomas-Gelf

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
5 participants
@friesoft @widhalmt @Thomas-Gelf @carraroj @phil-or