PropetyModifierToInt: fail for non-strings

fixes #2372
Icinga · Aug 12, 2021 · f87eff8 · f87eff8
1 parent 909fac0
commit f87eff8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/doc/82-Changelog.md b/doc/82-Changelog.md
@@ -13,6 +13,7 @@ next (will be 1.9.0)
 
 ### Import and Sync
 * FIX: string property modifiers now preserve NULL values (#2371)
+* FIX: "to int" property modifiers now fails for non-string values (#2372)
 * FEATURE: introduce 'disable' as your purge action on Sync (#2285)
 * FEATURE: there is now a simple "group by" Property Modifier (#2317)
 

diff --git a/library/Director/PropertyModifier/PropertyModifierToInt.php b/library/Director/PropertyModifier/PropertyModifierToInt.php
@@ -2,6 +2,7 @@
 
 namespace Icinga\Module\Director\PropertyModifier;
 
+use Icinga\Module\Director\Data\InvalidDataException;
 use Icinga\Module\Director\Hook\PropertyModifierHook;
 
 class PropertyModifierToInt extends PropertyModifierHook
@@ -24,5 +25,7 @@ public function transform($value)
         if (is_string($value)) {
             return (int) $value;
         }
+
+        throw new InvalidDataException('String, integer or null', $value);
     }
 }