Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI for restrictions #124

Closed
dgoetz opened this issue Mar 31, 2017 · 3 comments · Fixed by #288
Closed

Add GUI for restrictions #124

dgoetz opened this issue Mar 31, 2017 · 3 comments · Fixed by #288
Labels
enhancement New feature or improvement
Milestone

Comments

@dgoetz
Copy link
Contributor

dgoetz commented Mar 31, 2017

As a follow up on #103 and #98 I would like to have a GUI element to define restrictions.

Depending on the environment perhaps not all users/groups/roles should be allowed for sharing, so adding something like it is already implemented for navigation items could be useful. Also administrative access overriding all restrictions is something I see as a requirement.

An real world example:

  • The Icinga-Admin would like to be able see and edit all business processes to help the admins
  • The Admin of one toolstack would like to be able see and edit business processes for its tools, same goes for others
  • The Manager of some admin teams would like to see and perhaps simulate business processes of those teams but not all
  • One team would like to see business process of another (and use the nodes defined by them) as the service they manage depends on the service of the other team
@nilmerg
Copy link
Member

nilmerg commented Feb 19, 2019

Since #200 is closed the permission businessprocess/showall circumvents all restrictions. Each role also allows to restrict configuration access based on prefixes. Though, only one prefix per role as of yet.

So:

  • Use the permission businessprocess/showall for that
  • Configure a role for the toolstack with a specific prefix
  • Add those managers to the above mentioned roles
  • Again, add those teams to the above mentioned roles

Solved?

@nilmerg nilmerg added the needs-feedback We'll only proceed once we hear from you again label Feb 19, 2019
@dgoetz
Copy link
Contributor Author

dgoetz commented Feb 19, 2019

Not completely as I also would like to be able to use the in #98 mentioned fine-granular permissions in the GUI.

@nilmerg
Copy link
Member

nilmerg commented Feb 19, 2019

Ah, thanks. The relevant quote:

The correct spelling for those properties is AllowedUsers, AllowedGroups and AllowedRoles. Their value needs to be a comma-separated list. As soon as there is one of those headers in a process config file, only users fitting any of those filters, the one listed as Owner and users with wildcard permissions are allowed to see the process.

It would have been easy to add form fields for the above, but once we planned doing so immediately other questions arose. When you are allowed to share, to whom should you be able to do so? Should you be allowed to see those users, groups or roles? Should you be allowed to see your own ones? How do you hinder other users from spamming your menu? Should we also add the possibility to share it in a read-only and in a read-write way? Only to specific users?

As this started to become a huuuuge discussion, we decided to defer this feature. Still, don't fear to use those restrictions by manually setting them. They are supported and will not be broken in a future release. At least not without a defined migration path in case we eventually decide to change everything ;-)

@nilmerg nilmerg added enhancement New feature or improvement needs-sponsoring Not low on priority but also not scheduled soon without any incentive and removed needs-feedback We'll only proceed once we hear from you again labels Feb 19, 2019
dgoetz added a commit to dgoetz/icingaweb2-module-businessprocess that referenced this issue Dec 15, 2020
dgoetz added a commit to dgoetz/icingaweb2-module-businessprocess that referenced this issue Dec 15, 2020
nilmerg pushed a commit to dgoetz/icingaweb2-module-businessprocess that referenced this issue Mar 16, 2022
nilmerg pushed a commit to dgoetz/icingaweb2-module-businessprocess that referenced this issue Mar 16, 2022
nilmerg pushed a commit to dgoetz/icingaweb2-module-businessprocess that referenced this issue Mar 16, 2022
@nilmerg nilmerg removed the needs-sponsoring Not low on priority but also not scheduled soon without any incentive label Mar 16, 2022
@nilmerg nilmerg added this to the 2.4.0 milestone Mar 16, 2022
nilmerg pushed a commit that referenced this issue Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants