Skip to content

Commit

Permalink
Remove todo note about previous commit
Browse files Browse the repository at this point in the history
  • Loading branch information
Icelk committed Nov 19, 2023
1 parent 7694339 commit 34bb1c6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,10 @@ impl RunConfig {

// artefact from ↑. When not uring, the outer vec is 1 in length
let mut all_listeners: Vec<
Vec<(Box<dyn Fn() -> AcceptManager + Send + Sync>, Arc<PortDescriptor>)>,
Vec<(
Box<dyn Fn() -> AcceptManager + Send + Sync>,
Arc<PortDescriptor>,
)>,
> = Vec::with_capacity(instances);

let ports: Vec<_> = ports.into_iter().map(Arc::new).collect();
Expand Down Expand Up @@ -475,9 +478,6 @@ impl RunConfig {
let shutdown_manager = Arc::clone(&shutdown_manager);
std::thread::spawn(move || {
tokio_uring::start(async move {
// `TODO`: seems like tokio-uring sometimes segfaults when exiting. Maybe
// this has to do with sockets being moved between runtimes?
// Is a socket registered on another runtime also slowing things down?
accept(listener(), descriptor, &shutdown_manager, n == 0)
.await
.expect("failed to accept message");
Expand Down
2 changes: 1 addition & 1 deletion src/shutdown.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ pub struct Manager {
pub(crate) handover_socket_path: Option<PathBuf>,
}
unsafe impl Send for Manager {}
unsafe impl Sync for Manager{}
unsafe impl Sync for Manager {}
impl Manager {
/// Creates a new shutdown manager with the capacity of the list of wakers set to `_capacity`.
///
Expand Down

0 comments on commit 34bb1c6

Please sign in to comment.